New Workload: Babylon class-heavy workload #143
+111,108
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
camillobruni
changed the title
|
Can we add the |
- use unicode converter plugin - Use startup-helpers
|
It seems like the scene workloads seem to block or stall for several seconds in Safari but not JSC cli or other browsers. Have you seen that at all? I can investigate more tomorrow, if not. 
vs JSC cli, which is much more reasonable: 
|
…-14_class-startup
- Use Object.keys to access exported names intead of the more uncomment class names - Monkey patch setTimeout that was accidentally used in the scene - Move cheap validation into the runIteration to leak fewer objects across iterations
|
I've now patched setTimeout for both workloads. I think this was accidentally used in the scene workload. Could you double check again whether this is still blocking / adding dead time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the same cache-busting pattern, I've created a Babylon.js-based startup workload.
There is an ES6 and ES5 version of the same workload and they both heavily stress parse+top-level setup code with many classes.